PreviousNextTracker indexSee it online !

(299/329) 1730 - JavaSideKick "Imports" Asset not foldable sometimes if there are blank lines between imports?

It should be so the imports can be folded like the other assets.

Submitted ezust - 2013-08-15 07:12:04 Assigned daleanson
Priority 5 Labels
Status open Group
Resolution None

Comments

2013-11-11 23:51:58
daleanson

Works for me. Do you have a specific file this isn't working with?

2013-11-22 03:49:48
ezust

I guess for some Java files it works, but for others it doesn't.
One example where it does not work is in fastopen plugin, the FastOpenPlugin.java
When I parse it, sometimes I only see one import in the sidekick tree, other times I see all of the imports.
But regardless, the imports section is not foldable.

2014-03-31 23:00:15.658000
daleanson

Tested with JavaSideKick 3.1.5, SideKick 1.4, jEdit 5.2pre1, and FastOpenPlugin.java and it works fine. Any other file you're seeing this doesn't work with?

2014-03-31 23:04:18.735000
daleanson

Actually, I see that 3.1.5 was released about a year and a half ago and there are some decent changes since then. Are you using the release version or did you build it from trunk?

2014-04-02 21:30:58.122000
ezust

For another example, try GUIUtilities.java from jEdit's source, however, you have to modify the buffer-local properties at the top from folding=explicit to folding=sidekick to see the problem.

2014-04-02 21:35:43.713000
ezust

After updating to the latest trunk of JavaSideKick, my original example where i saw the problem in FastOpenPlugin.java, it seems to be fixed now. So I am not sure why GUIUtilities still has problems but FastOpen.java imports fold fine now.

2014-04-02 22:20:46.476000
daleanson

I'm not sure either. GUIUtilities.java works fine for me too.

2014-04-02 22:30:47.846000
ezust

For you, does it really fold all imports from lines 25-71?
For me, I get 4 different folding regions!!
Screenshot attached.

2014-04-03 15:25:09.734000
daleanson

Oh, you're talking about the folding in the text area, right? I also have 4 different folding regions, but not that's part of JavaSideKick, it's part of SideKick itself. JavaSideKick doesn't provide a fold handler of it own, maybe it should?